Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Books Page List Section Design #9509

Open
3 tasks
mekarpeles opened this issue Jul 1, 2024 · 3 comments
Open
3 tasks

Update Books Page List Section Design #9509

mekarpeles opened this issue Jul 1, 2024 · 3 comments
Assignees
Labels
Affects: Experience Issues relating directly to service design & patrons experience Fellowship Opportunity Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Community Discussion This issue is to be brought up in the next community call. [managed] Needs: Design Feedback Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Performance Issues related to UI or Server performance. [managed] Type: Design Proposal Proposing a design and soliciting feedback + approval Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Type: Proposal

Comments

@mekarpeles
Copy link
Member

Problem

A clear and concise description of what you want to happen

Update the Books Page List Section Design
Add List Owner's Avatar Image to List Preview

Before
Screenshot 2024-07-01 at 10 11 14 AM

After
Screenshot 2024-07-01 at 10 28 53 AM

This after design can already be seen at the bottom of the "My Books" page (e.g. https://openlibrary.org/people/mekBot/books)

  • Add patron avatar to existing My Books design
  • Redesign Books Page lists section to only be a single row of up to 5 lists
  • Make sure each list card is cached for performance

Proposal & Constraints

No response

Leads

Related files

Stakeholders


### Instructions for Contributors - Please [run these commands](https://github.com/internetarchive/openlibrary/wiki/Git-Cheat-Sheet#working-on-your-branch) to ensure your repository is up to date **before** [creating a new branch](https://github.com/internetarchive/openlibrary/wiki/Git-Cheat-Sheet#making-changes-and-creating-a-pull-request) to work on this issue and **each time after** pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@mekarpeles mekarpeles added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Theme: Performance Issues related to UI or Server performance. [managed] Priority: 2 Important, as time permits. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Affects: Experience Issues relating directly to service design & patrons experience Fellowship Opportunity labels Jul 1, 2024
@mekarpeles
Copy link
Member Author

@benbdeitch any chance you may be open to helping mentor this one?

@mekarpeles mekarpeles removed the Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] label Jul 1, 2024
@prasad14070
Copy link

Hello @mekarpeles can I work on this issue.

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Jul 6, 2024
@mekarpeles mekarpeles added Needs: Community Discussion This issue is to be brought up in the next community call. [managed] Needs: Design Feedback Type: Proposal Type: Design Proposal Proposing a design and soliciting feedback + approval labels Jul 8, 2024
@mekarpeles
Copy link
Member Author

mekarpeles commented Jul 8, 2024

For now, let's go with a card design that looks like those above, however, below the Title and above the book count we have by: <creator> and we can discuss the specific design once we have a PR to talk about.

In the current model we source our Lists from 2 queries:

  • 1 for Lists containing this Edition
  • 1 for Lists containing this Work

Let's try to keep this pretty much as it is and limit the number of cards we show to 5. We can figure out exact balance in PR review

@mekarpeles mekarpeles removed the Needs: Response Issues which require feedback from lead label Jul 8, 2024
@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] and removed Priority: 2 Important, as time permits. [managed] labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Experience Issues relating directly to service design & patrons experience Fellowship Opportunity Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Community Discussion This issue is to be brought up in the next community call. [managed] Needs: Design Feedback Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Performance Issues related to UI or Server performance. [managed] Type: Design Proposal Proposing a design and soliciting feedback + approval Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Type: Proposal
Projects
None yet
Development

No branches or pull requests

2 participants