Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "Yearly Reading Goals" from My Books body to Sidebar menu #10011

Open
mekarpeles opened this issue Nov 8, 2024 · 1 comment · May be fixed by #10085
Open

Move "Yearly Reading Goals" from My Books body to Sidebar menu #10011

mekarpeles opened this issue Nov 8, 2024 · 1 comment · May be fixed by #10085
Assignees
@schu96
Labels
Fellowship Opportunity Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Design Feedback Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Theme: My Books Type: Design Proposal Proposing a design and soliciting feedback + approval

Comments

@mekarpeles
Copy link
Member

Description, Patron Story

  • What is the design change?

Move "Yearly Reading Goals" from My Books home to the My Books Sidebar. Also, consider removing the modal / alert banner if no goal is set from the books page and instead showing text in this area that says, "set 2024 reading goal".

  • Why is this design change necessary?

So its always visible on each page and also takes up less prime real estate

  • Who is it for?

All registered patrons

Relevant Designs

Before
image

After
Screenshot 2024-11-07 at 9 34 43 PM

See: https://www.figma.com/design/dYQkIJOJeMo9hx7ewZQH9x/Open-Library%3A-Design-System-%26-Component-Library?node-id=1956-427&node-type=frame&t=ny7I7uZBshygPSsH-0
@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Theme: My Books Type: Design Proposal Proposing a design and soliciting feedback + approval Needs: Design Feedback Fellowship Opportunity Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] and removed Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] labels Nov 8, 2024
@schu96
Copy link
Contributor

schu96 commented Nov 18, 2024

@jimchamp I'd like to be assigned to this issue

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Nov 19, 2024
@jimchamp jimchamp removed the Needs: Response Issues which require feedback from lead label Nov 19, 2024
@schu96 schu96 linked a pull request Nov 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schu96 schu96

Labels
Fellowship Opportunity Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Design Feedback Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Theme: My Books Type: Design Proposal Proposing a design and soliciting feedback + approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move Yearly Reading Goal to sidebar schu96/openlibrary
3 participants
@mekarpeles @schu96 @jimchamp