Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting the "Search inside" tab by date published #10084

Open
el4ctr0n opened this issue Nov 25, 2024 · 1 comment
Open

Sorting the "Search inside" tab by date published #10084

el4ctr0n opened this issue Nov 25, 2024 · 1 comment
Assignees
Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@el4ctr0n
Copy link

el4ctr0n commented Nov 25, 2024

Proposal

Dear developers,
Can you please make it possible to sort the search results in the "Search inside" tab by the date of publication (the "First Published" and "Most Recent" sorting options in the dropdown menu)?

Sorting

389641599-b6c8cc4d-3e42-4477-85e5-6f5cd64f6fd0

It would also be great if the search results in the "Search inside" tab included the year when the book was originally published, just like it's already included in the "Books" tab:
FirstPublished

I appreciate you considering this feature request.

Justification

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders


Instructions for Contributors

Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

@el4ctr0n el4ctr0n added Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] labels Nov 25, 2024
@mekarpeles
Copy link
Member

This may be a more challenging issue than one might initially thing because the search inside function is run by archive.org's Elastic Search engine which is different than Open Library's search endpoint.

This means, we could implement the sorts shown on archive.org for full-text search
https://archive.org/search?query=book+of+mormon&sin=TXT&sort=-date (which includes publication date and title), however it may be challenging to extend the existing Open Library sort UI (based on solr). @el4ctr0n if you'd like to give it a try (i.e. passing a sort parameter through to our call to Archive.org Elastic Search) feel free :)

@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

No branches or pull requests

2 participants