Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify whitespace on search results pages (when no search results). #10067

Open
1 task
Tracked by #9232
RayBB opened this issue Nov 22, 2024 · 9 comments
Open
1 task
Tracked by #9232

Unify whitespace on search results pages (when no search results). #10067

RayBB opened this issue Nov 22, 2024 · 9 comments
Assignees
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Bug Something isn't working. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Nov 22, 2024

Problem

Follow up to #10056
Part of #9232

As you can see below, there is a different amount of whitespace below each search result page.
We should unify them to all match the heights on the "all" and "lists" pages.

ezgif com-optipng

Reproducing the bug

See photos above

Context

  • Browser (Chrome, Safari, Firefox, etc): FF
  • OS (Windows, Mac, etc): Mac
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • All pages have the same whitespace

Related files

  • See openlibrary/templates/search/

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@RayBB RayBB added Type: Bug Something isn't working. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] labels Nov 22, 2024
@Sahil-Gupta584
Copy link

hey @RayBB i would like to work on it

@shikharchaurasia
Copy link

Hello, I would like to work on this issue. Could this please be assigned to me?

@RayBB
Copy link
Collaborator Author

RayBB commented Nov 23, 2024

@Sahil-Gupta584 since you commented first you're assigned.

However I'd like to ask you both @shikharchaurasia how did you find this issue? What are the odds you find it within a minute or each other.

@Sahil-Gupta584
Copy link

@Sahil-Gupta584 since you commented first you're assigned.

However I'd like to ask you both @shikharchaurasia how did you find this issue? What are the odds you find it within a minute or each other.

I dont know ,maybe just a co-incident.

@shikharchaurasia
Copy link

@RayBB I was searching for open source issues to contribute towards. I was browsing through good first issues on this repository. As for the time interval, must have been a coincidence as I do not know the other person :)

@Sahil-Gupta584 Sahil-Gupta584 removed their assignment Nov 23, 2024
@Sahil-Gupta584
Copy link

@RayBB sorry i will not able to contribute to this repo as i am JS developer while setting up gitpod i got to know repo is python based , is there any other repo from Internet Archive where i can contribute to?

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Nov 23, 2024
@RayBB
Copy link
Collaborator Author

RayBB commented Nov 23, 2024

@shikharchaurasia I've assigned you now since you were next in line.

@Kvothe045
Copy link

@RayBB hey! I can work on this issue

@RayBB
Copy link
Collaborator Author

RayBB commented Nov 24, 2024

@Kvothe045 please choose an issue that's not assigned to someone.

@RayBB RayBB added Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] and removed Needs: Response Issues which require feedback from lead labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

No branches or pull requests

4 participants