-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify whitespace on search results pages (when no search results). #10067
Comments
hey @RayBB i would like to work on it |
Hello, I would like to work on this issue. Could this please be assigned to me? |
@Sahil-Gupta584 since you commented first you're assigned. However I'd like to ask you both @shikharchaurasia how did you find this issue? What are the odds you find it within a minute or each other. |
I dont know ,maybe just a co-incident. |
@RayBB I was searching for open source issues to contribute towards. I was browsing through good first issues on this repository. As for the time interval, must have been a coincidence as I do not know the other person :) |
@RayBB sorry i will not able to contribute to this repo as i am JS developer while setting up gitpod i got to know repo is python based , is there any other repo from Internet Archive where i can contribute to? |
@shikharchaurasia I've assigned you now since you were next in line. |
@RayBB hey! I can work on this issue |
@Kvothe045 please choose an issue that's not assigned to someone. |
Problem
Follow up to #10056
Part of #9232
As you can see below, there is a different amount of whitespace below each search result page.
We should unify them to all match the heights on the "all" and "lists" pages.
Reproducing the bug
See photos above
Context
Breakdown
Requirements Checklist
Related files
openlibrary/templates/search/
Stakeholders
Instructions for Contributors
The text was updated successfully, but these errors were encountered: