Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable popups so we don't show too many items #169

Open
yochannah opened this issue Feb 26, 2019 · 7 comments
Open

Configurable popups so we don't show too many items #169

yochannah opened this issue Feb 26, 2019 · 7 comments
Assignees

Comments

@yochannah
Copy link
Member

Reported by @kkarra: right now it looks like we show all attributes of a class which isn't desirable behaviour if there are a lot of attributes. if the class for a given cell has 40+ attributes, all 40 show in the popover. We should limit this to summary fields and/or make it configurable.

Screenshot from YeastMine:
image

Some investigation notes:

At first I thought this might be a problem on the InterMine side because the same thing happened in BluegGenes, where tables look similar but have a totally different codebase.... but I managed to fix the bug in bluegenes, which quite clearly was iterating through all the attributes. I think im-tables js is doing the same, but I haven't been able to spot exactly where yet. It might even be configurable (see the imtables configuring notes and options.coffee - but as noted in #92, not all options are clearly documented :(

@Manasa2850
Copy link
Contributor

@yochannah could I work on this?

@Manasa2850
Copy link
Contributor

@yochannah I looked up the codebase to find the files relavant to this issue. As per my understanding, in order to resolve this issue we need to make changes to the way im-field-name and im-field-value are called.
Could you please help me with finding out where exactly we need to make these changes?
Thanks!

@yochannah
Copy link
Member Author

okay - I searched the codebase for im-field-value and found the cell-preview-reference template. searching again for cell-preview-reference found this: https://github.com/intermine/im-tables/blob/b2c60690511981a4fed68fbb9848a14a2cecff07/src/views/item-preview/details.coffee

I suspect we need to somehow limit what is output - any suggestions about a good way to go about this? If not let me know and we can brainstorm.

@kkarra
Copy link

kkarra commented Mar 13, 2020

It looks like the display order of items in the pop-up box is by alphabetical sort of column names. Not sure how much work any other approach will involve, but, simply cutting if off at a certain count say 10 would be fine too. If possible, can have More... be displayed or some such that can take to report page of the object in question.

@Manasa2850
Copy link
Contributor

@yochannah I would suggest we have something like what is shown in the image. Clicking on a particular alphabet will display all the attributes starting with that alphabet.
p1

I don't think selecting the first/last 10 outputs will be a good choice because there might be other attributes which the user may consider important.

@kkarra
Copy link

kkarra commented Mar 15, 2020

We are talking about a pop-up box on results page. I don't foresee users browsing an alphabetized list for that.

@yochannah
Copy link
Member Author

@Manasa2850 - I'd suggest going with @kkarra's suggestion here. Truncate at 10 items and offer "more" if possible ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants