Fix off by one error

interlynk-io · Apr 9, 2024 · 7f370f4 · 7f370f4
1 parent 2eaa7d6
commit 7f370f4
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/pkg/scorer/ntia.go b/pkg/scorer/ntia.go
@@ -98,8 +98,11 @@ func compWithUniqIDCheck(d sbom.Document, c *check) score {
 		return *s
 	}
 
-	compIDs := lo.Map(d.Components(), func(c sbom.Component, i int) string {
-		return strings.Join([]string{d.Spec().Namespace(), c.ID()}, "")
+	compIDs := lo.FilterMap(d.Components(), func(c sbom.Component, i int) (string, bool) {
+		if c.ID() == "" {
+			return "", false
+		}
+		return strings.Join([]string{d.Spec().Namespace(), c.ID()}, ""), true
 	})
 
 	uniqComps := lo.Uniq(compIDs)