Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the loans reserve #1067

Open
daniel-savu opened this issue May 23, 2023 · 0 comments
Open

Fix the loans reserve #1067

daniel-savu opened this issue May 23, 2023 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@daniel-savu
Copy link
Contributor

daniel-savu commented May 23, 2023

Describe the bug
Currently, the reserve cash does not contribute to market liquidity. There is a mismatch between the implementation in the interbtc loans pallet and that in Compound v2. This PR further documents the issue and is an initial attempt at fixing the problem.

Also see my questions in the Compound Discord:

Expected behavior
Without the reserve contributing to protocol liquidity, the add_reserves extrinsic has no utility and should be removed. Otherwise, the reserve should serve as a way for protocol governance to add exit liquidity for redeemers in case 100% utilization is achieved.

Context
See these associated code TODOs:

@daniel-savu daniel-savu added the bug Something isn't working label May 23, 2023
@daniel-savu daniel-savu added this to the Lend / Borrow milestone May 23, 2023
@nud3l nud3l added this to Backlog May 23, 2023
@github-project-automation github-project-automation bot moved this to New 🆕 in Backlog May 23, 2023
@nud3l nud3l moved this from New 🆕 to Todo ⏳ in Backlog May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant