Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RateLimitRoundtripper): Fix mutex leak and not respecting context cancellation #2298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pete-woods
Copy link

@pete-woods pete-woods commented Jun 26, 2024

Resolves #2299


Before the change?

  • Cancellation is not being respected in the transport's sleeps.
  • Additionally, there's a path out of the function that does not unlock the mutex.

After the change?

  • Cancellation is now respected, and the mutex always unlocks.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@pete-woods pete-woods changed the title RateLimitRoundtripper: Fix mutex leak and not respecting context cancellation fix(RateLimitRoundtripper): Fix mutex leak and not respecting context cancellation Jun 26, 2024
@pete-woods pete-woods marked this pull request as ready for review June 26, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Cancelling terraform apply hangs indefinitely
1 participant