Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit Actual Android Detector Size #2

Open
forrestmid opened this issue Mar 4, 2018 · 1 comment
Open

Limit Actual Android Detector Size #2

forrestmid opened this issue Mar 4, 2018 · 1 comment
Labels
bug help wanted

Comments

@forrestmid
Copy link
Contributor

Limit scannable area to within the detector area.
forrestmid added a commit that referenced this issue Jan 23, 2019
@forrestmid
#2 Initial Cropping of Viewfinder, needs more testing.
38c3aab
@forrestmid
Copy link
Contributor Author

I've put up my initial commit to solve this issue on another branch. There's an odd bug with it where the right side of the detector range extends slightly past the viewfinder. If someone can test out the code with different viewport sizes/devices, and perhaps submit a PR that fixes the detector size issue, that would be great!

rctsteven referenced this issue in rctsteven/cordova-plugin-barcode-detector Feb 10, 2020
commit flobiwankenobi#2
d586d15 
Commented out all lines referencing viewfinder(white rectangle)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@forrestmid