Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem including dev.h in C++ compiler #2

Open
misirlou-tg opened this issue Nov 1, 2021 · 0 comments
Open

Problem including dev.h in C++ compiler #2

misirlou-tg opened this issue Nov 1, 2021 · 0 comments

Comments

@misirlou-tg
Copy link

The file include/public/sercomm/dev.h should end with SER_END_DECL, there is a typo it ends with SER_BEGIN_DECL

vicroms pushed a commit to microsoft/vcpkg that referenced this issue Mar 8, 2024
this fixes a typo in sercomm/dev.h that results in errors when included
in C++

- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [ ] ~SHA512s are updated for each updated download.~
- [ ] ~The "supports" clause reflects platforms that may be fixed by
this new version.~
- [ ] ~Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.~
- [ ] ~Any patches that are no longer applied are deleted from the
port's directory.~
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.

why a patch?
[upstream](https://github.com/ingeniamc/sercomm) seems to be
unmaintained, an [issue](ingeniamc/sercomm#2)
& a [pull request](ingeniamc/sercomm#3)
regarding this issue have existed for years/months respectively
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant