Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve configuration max_block_time validation #4147

Open
5 tasks
ljoss17 opened this issue Aug 14, 2024 · 1 comment
Open
5 tasks

Improve configuration max_block_time validation #4147

ljoss17 opened this issue Aug 14, 2024 · 1 comment

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Aug 14, 2024

Summary

For the max_block_time configuration Hermes will query the value on chain and verify if the configured value matches the queried value.

In Hermes v1.10.1, if the max_block_time is not configured, it will default to 30s and the value will be updated with the queried max_expected_time_per_block if it differs from 30s.

From this discussion, #4144 (comment), the desired behaviour would be the following:

  • If max_block_time is configured:
    • Query max_expected_time_per_block and output a warning if the queried value differs from the configured one, but keep the configured value
    • If the query fails, keep the configured value
  • If max_block_time is not configured:
    • Query max_expected_time_per_block and use that value for max_block_time
    • If the query fails, use the default value, 30s, for max_block_time

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir
Copy link
Collaborator

It's worth to review the handling of other configuration options as part of this issue, i believe there might be more cases like this as i see some cmd.override_config() calls for example. At some point a small doc that describes the general approach would be also good.

All said, i think this should be low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🩹 Triage
Development

No branches or pull requests

2 participants