Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPROTO-394 Optimize TagWriterImpl#writeString for ASCII only Strings #336

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

IPROTO-394 Optimize TagWriterImpl#writeString for ASCII only Strings #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions core/src/main/java/org/infinispan/protostream/impl/TagWriterImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,13 +131,30 @@ public void writeVarint64(long value) throws IOException {
encoder.writeVarint64(value);
}

public static boolean onlyAscii(String ba, int off, int len) {
int limit = off + len;
for (int i = off; i < limit; i++) {
if (ba.charAt(i) > 127) {
return false;
}
}
return true;
}

@Override
public void writeString(int number, String value) throws IOException {
// TODO [anistor] This is expensive! What can we do to make it more efficient?
public void writeString(int number, String s) throws IOException {
// Also, when just count bytes for message size we do a useless first conversion, and another one will follow later.

if (onlyAscii(s, 0, s.length())) {
encoder.writeLengthDelimitedField(number, s.length());
for (int i = 0; i < s.length(); ++i) {
encoder.writeByte((byte) s.charAt(i));
}
return;
}

// Charset.encode is not able to encode directly into our own buffers!
byte[] utf8buffer = value.getBytes(StandardCharsets.UTF_8);
byte[] utf8buffer = s.getBytes(StandardCharsets.UTF_8);

encoder.writeLengthDelimitedField(number, utf8buffer.length);
encoder.writeBytes(utf8buffer, 0, utf8buffer.length);
Expand Down