Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider shifting from raw print statements to using canonical logging #141

Open
scott-carroll-verses-ai opened this issue Jun 12, 2024 · 1 comment

Comments

@scott-carroll-verses-ai

I see that there are a lot of print statements build into the library (e.g. print(f'Factorized version: lnA at time {t}: {lnA}') in pymdp/algos/mmp.py). It would be preferrable to use a canonical logging library. This is a little article making the case for using logging rather than raw print statements: https://www.loggly.com/blog/4-reasons-a-python-logging-library-is-much-better-than-putting-print-statements-everywhere/

@conorheins
Copy link
Collaborator

Thanks a lot for this suggestion @scott-carroll-verses-ai , will look into this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants