Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable i18n not working as expected #491

Closed
dzhuang opened this issue Mar 12, 2018 · 8 comments
Closed

DataTable i18n not working as expected #491

dzhuang opened this issue Mar 12, 2018 · 8 comments

Comments

@dzhuang
Copy link
Contributor

dzhuang commented Mar 12, 2018

@ishitatsuyuki According to DataTables/Plugins#192, the lang files contains comments and the reponse are not json. So i18n of DataTable is not working as expected.

@dzhuang
Copy link
Contributor Author

dzhuang commented Mar 12, 2018

@ishitatsuyuki
Copy link
Contributor

To workaround, we possibly could link to the CDN versions mentioned in that issue.

@dzhuang
Copy link
Contributor Author

dzhuang commented Mar 12, 2018

I think pycountry is a little heavy for this functionality. I'd rather cook a new repo with npm to solve that.

@JonGarbayo
Copy link

For me (on 1.10.15 version), "not working as expected" is not really accurate: it's not working at all, every string stays in English.

@dzhuang, did you created a public npm repo with that problem fixed :) ?

@inducer
Copy link
Owner

inducer commented Aug 26, 2019

Thanks for reporting this. I think this might be a DataTables issue. Relate sets this up as described, and as far as I can tell, the files are there, but there isn't even an HTTP request for them. I'd be grateful if you could investigate what's happening.

@inducer inducer reopened this Aug 26, 2019
@dzhuang
Copy link
Contributor Author

dzhuang commented Aug 27, 2019

@JonGarbayo Did you see this commit (7048045) which closed this issue? We have been using https://github.com/dzhuang/datatables-i18n for the langs.

@JonGarbayo
Copy link

Oh I am really sorry: I landed here searching for a fix for that not working Datatables .lang files, but I didn't see I was not on a Datatables GitHub repo 😅

I don't use relate, so I am not aware of the state of the problem here, sorry.

@dzhuang
Copy link
Contributor Author

dzhuang commented Aug 27, 2019

@JonGarbayo It's ok. And I think our fix might be helpful for you.

@dzhuang dzhuang closed this as completed Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants