Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customized invoice number #50

Open
ThiefMaster opened this issue Jul 20, 2017 · 4 comments
Open

Allow customized invoice number #50

ThiefMaster opened this issue Jul 20, 2017 · 4 comments

Comments

@ThiefMaster
Copy link
Member

ThiefMaster commented Jul 20, 2017

I need an invoice number (also for possible other payment plugins) that is compatible to our books (e.g. the correct cost center)

Currently it's hardcoded:

<input type="hidden" name="invoice" value="{{ registration.event_id }}_{{ registration.id }}">

It would be nice to allow some placeholders to be configured, just like we do in payment_manual. There would be an option in the plugin's settings for the default and another one in the plugin's event settings so it can be customized on the event level.

@ThiefMaster
Copy link
Member Author

Note: Whoever works on this, please check if PayPal has any restrictions on what can be used in the "invoice" argument and if there are any, these restrictions should be applied after replacing the placeholders.

@Problemkerze
Copy link

Note: Would be nice if this was a event-wide-variable so that other payment plugins could use this argument, too.

@ThiefMaster
Copy link
Member Author

Since various payment systems may have different restrictions (and maybe not all of them use something like an invoice number at all) I think it makes more sense to keep the setting local to each payment plugin.

@Problemkerze
Copy link

I disagree. Nearly every payment system has an intended purpose where you usually state an invoice number. For the books of the event creator, some kind of prefix may be helpful (in our case it's the cost center, in other cases it may be the name of the event itself or something).
Should the payment system not give the possibility to include an intended purpose, you just don't use this variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants