Peer review managers csv #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micsucmed
force-pushed
the
peer-review-managers-csv
branch
2 times, most recently
from
e7d48d1
to
ebd3c4f
Compare
micsucmed
force-pushed
the
peer-review-managers-csv
branch
2 times, most recently
from
2baf11c
to
b4d0971
Compare
ThiefMaster
reviewed
Aug 20, 2024
micsucmed
force-pushed
the
peer-review-managers-csv
branch
from
5095bb1
to
84f36b6
Compare
ThiefMaster
force-pushed
the
peer-review-managers-csv
branch
from
84f36b6
to
86a327a
Compare
ThiefMaster
reviewed
Nov 6, 2024
| const [loading, setLoading] = useState(false) | ||
|
|
||
| const handleSubmit = async () => { | ||
| onChange(userIdentifiers) |
There was a problem hiding this comment.
When you import the same twice you end up with duplicates, and combined with duplicate key that's causing all kinds of issues (try removing the duplicates).
There was a problem hiding this comment.
I fixed this by overwriting the list instead of appending to it. Could generate a merged list as well since we have access to entries. Not sure if that's needed though.
ThiefMaster
force-pushed
the
peer-review-managers-csv
branch
from
86a327a
to
4e911a3
Compare
|
FYI I fixed ESLint and reformatted the files, but there are still a bunch of linter errors that need to be fixed manually (mostly proptypes). |
Create endpoint for CSV upload handle
Return unknown email addresses
Export endpoint not working
micsucmed
force-pushed
the
peer-review-managers-csv
branch
from
8195a9f
to
1c248c3
Compare
Rename homonymous variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11
depends on indico/indico#6408