Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give ability to change the default get separator #302

Open
gallofeliz opened this issue Jul 26, 2018 · 4 comments
Open

Give ability to change the default get separator #302

gallofeliz opened this issue Jul 26, 2018 · 4 comments

Comments

@gallofeliz
Copy link

Hi,

As it is possible to use "_" for env() and argv() (or '-'), it should be good te be able to configure the get separator.

Example :

{
    "database": {
        "user": "root"
    }
}

I would like to get database:user doing nconf.get('database.user'). It's more natural.

Regards

@mhamann mhamann changed the title Give ability to change de default get separator Give ability to change the default get separator Sep 9, 2018
@mhamann
Copy link
Collaborator

mhamann commented Sep 9, 2018

I think this is actually a bug, because it seems like it's supported, but isn't actually honored.

@mhamann
Copy link
Collaborator

mhamann commented Sep 9, 2018

PR created (#307), but will be held until we're ready to bump the major version (hopefully later this year), since it's a potentially breaking API change.

@gallofeliz
Copy link
Author

Ok, good !

@mhamann
Copy link
Collaborator

mhamann commented Jun 21, 2021

This is fixed/changed via #337 and will be released as part of v1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants