Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Comparison with HashMap #44

Open
bluss opened this issue Oct 14, 2017 · 5 comments
Open

DOC: Comparison with HashMap #44

bluss opened this issue Oct 14, 2017 · 5 comments

Comments

@bluss
Copy link
Member

bluss commented Oct 14, 2017

See the list here: rust-lang/rust#45273 (comment)

@nico-abram
Copy link

rustc now uses hashbrown right? It's also been a long time. It might be interesting to try this again?

@bluss
Copy link
Member Author

bluss commented Oct 18, 2019

Well, it's certain that indexmap doesn't compete with hashbrown for performance in general. There are some special cases where indexmap might be faster, like for example iteration.

@jonhoo
Copy link

jonhoo commented Jun 30, 2020

@bluss & @cuviper How feasible (if at all) do you think it is to make IndexMap wrap hashbrown rather than implement its own hash table from scratch? hashbrown has its "raw" API, which is intended exactly for when you need to have relatively low-level control over the hash table, and might make things easier?

I ask specifically because I've been seeing some pretty sad resizing behavior, which I've since built a fix for, but the way indexmap is currently organized, it seems very difficult to swap out its map implementation in the way I had hoped.

@cuviper
Copy link
Member

cuviper commented Jun 30, 2020

@jonhoo very feasible 🙂 #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants