Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty value for receiver_id in acoustic.receivers #333

Open
PietrH opened this issue Oct 22, 2024 · 4 comments
Open

Empty value for receiver_id in acoustic.receivers #333

PietrH opened this issue Oct 22, 2024 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested

Comments

@PietrH
Copy link
Member

PietrH commented Oct 22, 2024

The function list_receiver_ids() uses a very simple SQL query:

SELECT DISTINCT receiver FROM acoustic.receivers

One of the expectations we have for the result is that there will be no empty NA values. However, this test is currently failing.

  • Why would there ever be empty receiver_id's in this table?
@PietrH PietrH added bug Something isn't working question Further information is requested help wanted Extra attention is needed labels Oct 22, 2024
@PietrH
Copy link
Member Author

PietrH commented Oct 22, 2024

@PieterjanVerhelst Do you know why this could happen?

@PieterjanVerhelst
Copy link
Collaborator

That is indeed strange. Could you provide the network project codes for which the receiver id is empty? I can try to reproduce the example in RStudio.

@CLAUMEMO
Copy link

CLAUMEMO commented Nov 6, 2024

It is an error on our side.
They are receivers from the OTN exchange. Since April (release 3.1.0) there is a receivers model table, and that was not updated in the OTN-ETN exchange scripts. @paulfvliz is working on that now :)

@PietrH
Copy link
Member Author

PietrH commented Nov 6, 2024

Thanks for the update, please let me know when this is fixed so I can turn our test back on :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants