New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow .pull-review files to be hosted in a different repo from the code repo #84

Open

imsky opened this issue Dec 21, 2018 · 1 comment

Labels

feature

Owner

imsky commented Dec 21, 2018

could also allow a HTTP URL

imsky added the feature label

tayfun commented Jan 22, 2019

Environment variable is another good option which already exists as far as I can see. As in:

read -d '' PULL_REVIEW_CONFIG << EOF
> version: 1
> 
> max_files: 0
> min_reviewers: 2
> max_reviewers: 2
> EOF
docker run -e PULL_REVIEW_CONFIG="$PULL_REVIEW_CONFIG" imsky/pull-review https://github.com/my/pr/pull/83/ --github-token  my_token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment