Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generated output omits the override modifier #317

Open
NoNotNow opened this issue May 22, 2024 · 0 comments
Open

generated output omits the override modifier #317

NoNotNow opened this issue May 22, 2024 · 0 comments

Comments

@NoNotNow
Copy link

Bug Report

Protoc-Gen-TS Version: 0.8.0 (example version, replace with the actual version)

Environment:

  • Angular CLI: 17.3.7
  • Node: 20.13.1
  • Package Manager: npm 10.5.2
  • OS: win32 x64
  • Angular: 17.3.8

[email protected]

Description of the Problem:
When compiling the generated output with the provided environment, the TypeScript compiler throws an error due to missing override modifiers on methods that override members in the base class.

Error Message:

TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'Message'.

Generated output:
static deserializeBinary(bytes: Uint8Array): ClientCode

Expected output:
static override deserializeBinary(bytes: Uint8Array): ClientCode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant