Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of bufbuild/protobuf-es #1149

Open
euskadi31 opened this issue Jan 13, 2023 · 3 comments
Open

Add support of bufbuild/protobuf-es #1149

euskadi31 opened this issue Jan 13, 2023 · 3 comments

Comments

@euskadi31
Copy link

Hello,

Can you look at the possibility of using bufbuild/protobuf-es ?

See: https://github.com/bufbuild/protobuf-es

Thank You

@johanbrandhorst
Copy link
Contributor

I'd love to see this contributed, but if you're using protobuf-es, why not use https://buf.build/blog/connect-web-protobuf-grpc-in-the-browser too?

@euskadi31
Copy link
Author

I'd love to see this contributed, but if you're using protobuf-es, why not use https://buf.build/blog/connect-web-protobuf-grpc-in-the-browser too?

If I'm not mistaken, it doesn't support bidirectional streams.

@yurifedoseev
Copy link
Contributor

yurifedoseev commented Nov 9, 2023

I'd love to see this contributed, but if you're using protobuf-es, why not use https://buf.build/blog/connect-web-protobuf-grpc-in-the-browser too?

Connect-go forces to implement a custom interface which doesn't conform with the pure grpc. Like this

func (ps *PingServer) Ping(
  ctx context.Context,
  req *connect.Request[pingv1.PingRequest],
) (*connect.Response[pingv1.PingResponse], error) {

instead of

func (ps *PingServer) Ping(
  ctx context.Context,
  req *pingv1.PingRequest,
) (*pingv1.PingResponse, error) {

This is a blocker for my project were we can reuse grpc servers with 3 different transports: pure grpc, grpc-web and grtc (grpc over web-rtc data channel)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants