Skip to content
This repository has been archived by the owner on Jul 23, 2021. It is now read-only.

Investigate performance regression in Set#map() #213

Closed
Methuselah96 opened this issue Dec 14, 2020 · 2 comments
Closed

Investigate performance regression in Set#map() #213

Methuselah96 opened this issue Dec 14, 2020 · 2 comments
Milestone

Comments

@Methuselah96
Copy link

See #210 for why this issue exists.
See #211 for the code used in the benchmark.

image

@Methuselah96 Methuselah96 added this to the 4.0 milestone Dec 14, 2020
@Methuselah96 Methuselah96 changed the title Resolve performance regression in Set#map() Investigate performance regression in Set#map() Dec 14, 2020
@Methuselah96
Copy link
Author

Results after running outside of a VM:

image

@Methuselah96
Copy link
Author

Methuselah96 commented Dec 19, 2020

Looked into this quite a bit and tried a few alternative implementations (none of which had a definitive advantage over the current approach). At the end of the day, I'm not confident in the way that we are measuring performance (even with the same code, I've often seen benchmark differences of 10% and more). I am working on a more comprehensive strategy to determine what our overall performance goals are.

I re-ran some of the benchmarks outside of a VM context with slightly less worrying results (see screenshot below). Since we don't have a comprehensive plan of what performance levels are acceptable, I'm closing this for now (with a new issue to comes soon to discuss strategies for determining what our performance goals are: #214).

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant