Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crow: Skipped gates at high speeds (but not crashing)/Gates merge at high speeds #1

Open
imminentgloom opened this issue Oct 28, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@imminentgloom
Copy link
Owner

imminentgloom commented Oct 28, 2024

Triggers are sent faster than trigger length causing triggers to become a constant high gate (then crah crow, see #3),

Find shortest usable trigger+gap at max speed. If performance is poor, limit max trigger rate to speeds that work.

@300bpm = ~2ms trigger (no gaps), 1-(1.8-1.9(?)) ms triggers

set trigger length as function of bpm?

enc(), if 1
params:delta("clock_tempo", d)
pulse_dirty = true
end

if t[1].substep == 1 and pulse_dirty then
crow...action = pulse(bpm_to_pulse_length(), 10)
pulse_dirty = false
end

-- set a max pulse length and min pw%
-- length = length or pw_to_length()

@imminentgloom imminentgloom self-assigned this Oct 28, 2024
@imminentgloom imminentgloom added the bug Something isn't working label Oct 28, 2024
@imminentgloom
Copy link
Owner Author

shortest trigger is 0.0007 seconds

implement a speed limit as a param that filters triggers above that rate + enough time to reliably retrigger.

make fill rates configurable, with presets for full and a reasonable limit for crow+modular.

imminentgloom added a commit that referenced this issue Nov 1, 2024
Added symptomatic fix for issue #1
@imminentgloom
Copy link
Owner Author

imminentgloom commented Nov 1, 2024

possible fix:
get crow to sync with norns clock so i can send a table of 4x24 substeps for each step so that crow can iterate through them in sync to handle existing notes.
then update tables when new notes are added to reduce message volume (same method as now, bundle of four tracks state pr substep).

gate length should be ok at 1ms

@imminentgloom imminentgloom changed the title Crow: Gate stays high with rapid triggers Crow: Skipped gates at high speeds (but not crashing)/Gates merge at high speeds Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant