New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate possible regression in handling of fractional negative X1/Y1 crop coordinates #171

Open

lilith opened this issue Mar 9, 2016 · 0 comments

Labels

bug

Milestone

Member

lilith commented Mar 9, 2016

The behavior of negative values for X1/Y1 is not defined by our docs, but X2/Y2 values of zero or less are bottom/right relative.

We need to verify that V4 did not affect how we interpret negative X1/Y1 values.
https://github.com/imazen/resizer/blob/develop/Core/Util/PolygonMath.cs#L782-L786

There is a possibility that we could easily change how we interpret X1/Y1 values -0.5 <= x1/y1 <= 0.

lilith added the bug label

lilith added this to the V4.2 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment