Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@ substring parsing may be over-aggressive #53

Open
hinerm opened this issue Nov 30, 2015 · 1 comment
Open

@ substring parsing may be over-aggressive #53

hinerm opened this issue Nov 30, 2015 · 1 comment

Comments

@hinerm
Copy link
Member

hinerm commented Nov 30, 2015

See this forum post for the scenario
carandraug added a commit to carandraug/imagej-updater that referenced this issue Jun 7, 2018
@carandraug
Fix parsing of protocol/username/hostname from host string (issue ima…
a4a37e9 
…gej#53)

FilesUploader: remove logic of parsing the host string which is kinda
duplicated and have it as part of the UpdateSite class.
UpdateSite: set the upload protocol, username, and hostname as part of
setting the host string.
@carandraug
Copy link

I am facing a similar issue. If the host is something like ssh:carandraug@foo, then it would use ssh:carandraug as username. Seems like the code was only ignoring the protocol part if it was sftp. The changes in pull #68 try to reduce code duplication and fix the issue for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carandraug @hinerm