Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple aspect ratios #230

Open
Mth0158 opened this issue Dec 8, 2023 · 2 comments · May be fixed by #294
Open

Add support for multiple aspect ratios #230

Mth0158 opened this issue Dec 8, 2023 · 2 comments · May be fixed by #294
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Mth0158
Copy link
Collaborator

Mth0158 commented Dec 8, 2023

Like content_type, we should be able to support multiple aspect ratios.

Possible to get inspiration from this fork: master...nejdetkadir:active_storage_validations:master. But not too much because they modified the :with option, we would rather like something with :in like content_type validator does.

Do not forget to add tests to your validator update + update the associated matcher

Please notify the fork owner so he/she can update its gemfile

@Mth0158 Mth0158 added enhancement New feature or request good first issue Good for newcomers labels Dec 8, 2023
@mohammednasser-32
Copy link

Hello @Mth0158 , just checking before jumping in since this seems to be open for a while 😅 can I work on this?

@Mth0158
Copy link
Collaborator Author

Mth0158 commented Oct 27, 2024

Hi @mohammednasser-32
Yes, you can jump on it, let me know if you need any assistance:)

@mohammednasser-32 mohammednasser-32 linked a pull request Nov 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
2 participants