Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API docs for list of ranks? #18

Open
mlecoz opened this issue Apr 22, 2021 · 2 comments
Open

API docs for list of ranks? #18

mlecoz opened this issue Apr 22, 2021 · 2 comments

Comments

@mlecoz
Copy link

mlecoz commented Apr 22, 2021

Hi,

Thanks for the awesome API! Is there any documentation anywhere that lists all the possible ranks a celebration could have?

Thanks,
Marissa

@igneus
Copy link
Owner

igneus commented Jun 13, 2021

Hi, this is a known flaw of the current API design and once I get to work on this project again (the list of issues and unmerged pull requests being a sufficient testimony of how neglected it currently is), ranks will be reworked in a new version of the API and there will be a separate endpoint returning their list.

For now the only way to get a complete list of possible ranks is looking in the source code of the calendarium-romanum gem
https://github.com/igneus/calendarium-romanum/blob/45899a59db3506fee5e20682141a590561c68d9c/lib/calendarium-romanum/enums.rb#L109

@igneus
Copy link
Owner

igneus commented Jun 13, 2021

It may be worth noting that the ranks are not some kind of custom design, but an attempt to model, as accurately as possible, the ranking system codified in the Table of Liturgical Days - see https://www.ewtn.com/catholicism/library/liturgical-year-2193 towards the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants