Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The seeder code is not flexible enough #24

Open
chuoke opened this issue Nov 25, 2019 · 0 comments
Open

The seeder code is not flexible enough #24

chuoke opened this issue Nov 25, 2019 · 0 comments

Comments

@chuoke
Copy link

chuoke commented Nov 25, 2019

First I really thanks for your doing, this is a great packge.
And I hope this packge can be more wonderful.

I think there some code is not flexible, such as

$sql = 'SELECT MAX("right") as maxRight FROM geo';

Most case there has table prefix, full table name will be like prefix_geo.

By the way, what do you think of using Laravel Eloquent Model? Or using a config table name.

I hope I can pull some requests to contribute, but I don't know anything about geo system.

Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant