Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in Mk1-FHR model #332

Open
GiudGiud opened this issue Dec 6, 2023 · 0 comments
Open

Regression in Mk1-FHR model #332

GiudGiud opened this issue Dec 6, 2023 · 0 comments
Labels
bug Something isn't working model_maintenance Removing deprecation, adapting to new techniques for performance or usability

Comments

@GiudGiud
Copy link
Collaborator

GiudGiud commented Dec 6, 2023

Bug Description

Following the change in friction models and the correction of a problem with the mesh (see #323), the bypass fraction in the Mk1-FHR decreased to near 0 from a few per cent. The refined case also has difficulty converging from a non-initialized solution

We do expect a few per cent of bypass flow, and cases with high friction such as this one should converge fine.
With a coming better model, if we cannot figure out why the results are no longer as expected, we should remove this model from the test bed.

Steps to Reproduce

Run the Mk1 FHR model, analyze results

Impact

Incoming model removal

@GiudGiud GiudGiud added bug Something isn't working model_maintenance Removing deprecation, adapting to new techniques for performance or usability labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working model_maintenance Removing deprecation, adapting to new techniques for performance or usability
Projects
None yet
Development

No branches or pull requests

1 participant