-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Rate Limit #22
Comments
Done in #24 ✔ |
@pattacini FYI Although this solution works, I have changed the workflow a little bit, and instead of using a PAT, we're now using a github app to do all the API calls. We've used something similar to: https://github.com/peter-murray/workflow-application-token-action You can grant the exact permissions to an app, and with the workflow-application-token-action you can get a temporary token to do all API calls. This will no longer case any rate limit to be hit since the number is set a lot higher for apps. See: https://docs.github.com/en/developers/apps/rate-limits-for-github-apps Workflow will look something like:
I can't really make a PR, because without creating an app it's hard to tell if it works in your case. |
Thanks a lot @JeroenKnoops for this nice suggestion! |
I've incorporated your suggestion in the main README (see 46d1ee1), but with a second thought, I believe this further layer would add an unnecessary complication now as we rarely hit the rate limit. I'll certainly be considering this again in the future if I'll start out experiencing downgraded performances in our context. Thanks heaps for the nice feedback! |
We were having a lot of rate limit hits, because we were using the same user also for other actions like gathering metric with CHAOSS. That's why this was our solution. I just wanted to share it for the future or when other people have similar issues! :) |
Instead of letting the action fail because of having hit the rate limit, we may consider handling it through suitable wait states by reading relevant info via the API.
See:
The text was updated successfully, but these errors were encountered: