Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on the zero configuration of *_index_add of the simulated Mk5.1 hand #172

Closed
xEnVrE opened this issue Sep 13, 2023 · 8 comments · Fixed by #173
Closed

Clarification on the zero configuration of *_index_add of the simulated Mk5.1 hand #172

xEnVrE opened this issue Sep 13, 2023 · 8 comments · Fixed by #173
Assignees
Labels
domain-mechanics Related to Mechanics domain-software Related to Software report-bug Something isn't working team-fix Related to Team Fix

Comments

@xEnVrE
Copy link
Contributor

xEnVrE commented Sep 13, 2023

I am opening this to ask a clarification about the behavior of the *_index_add joint of the Mk5 .1 hand.

According to this comment, it was decided that the zero position of the index adduction is the one where the index is more distant from the other fingers, i.e.:

It seems that such new behavior has not been transferred correctly in the simulation:

index_add = 0

index_add = 15

I guess we should:

  • invert the direction of the axis of rotation
  • change the default configuration at startup in Gazebo

cc @Nicogene @pattacini @fiorisi

@pattacini
Copy link
Member

pattacini commented Sep 14, 2023

Good catch @xEnVrE 👍🏻

@Nicogene @mfussi66 please read up on the issue from https://github.com/icub-tech-iit/ergocub-design-lowerarm/issues/157#issuecomment-1660679203 onward for more info on that.

You were off. I tried to find out why we ended up with a different convention wrt the iCub hand but unsuccessfully. At this point, we ought to conform to the latest standard.

@pattacini pattacini added team-fix Related to Team Fix report-bug Something isn't working domain-software Related to Software labels Sep 14, 2023
@Nicogene
Copy link
Member

Nicogene commented Sep 14, 2023

Since creo2urdf assumes that in the simulation model, all the joints are in their zeros, I need that @Mick3Lozzo or @Lawproto to change the rest position of the index_add joints in the simulation model.

Or actually, maybe it is the chance for changing the range to -3 to 12 degrees, see #141

What about the thumb_add ? Also that has to be changed?

@Nicogene Nicogene added the domain-mechanics Related to Mechanics label Sep 14, 2023
@xEnVrE
Copy link
Contributor Author

xEnVrE commented Sep 14, 2023

Or actually, maybe it is the chance for changing the range to -3 to 12 degrees

I am a bit confused, isn't it an issue related to Mk5.0?

What about the thumb_add ? Also that has to be changed?

I would say no, but others might comment on this. The behavior of the thumb adduction is at the moment similar to that on the old iCub hands, i.e. 0.0 -> thumb within the plane of the palm, max -> thumb ~orthogonal to the palm or the like

@pattacini
Copy link
Member

Since creo2urdf assumes that in the simulation model, all the joints are in their zeros, I need that @Mick3Lozzo or @Lawproto to change the rest position of the index_add joints in the simulation model.

Let's do it.

@Lawproto
Copy link
Member

Lawproto commented Sep 14, 2023

@Nicogene @pattacini to sum it up, I inderstood I have to update the ergoCub 1.1 sim model with the new index position.

immagine

It this is the case, the index_add joint rom spans from 0 (figure) to 15°.
cc @fiorisi

@pattacini
Copy link
Member

Yep 👍🏻

@Lawproto
Copy link
Member

@Nicogene as discussed via call, I committed the sim_ergocub_1-1.asm in this position.

immagine

Now it's ready to fire some guns.

cc @pattacini

@Nicogene
Copy link
Member

After @Lawproto fix, here is the PR that port those changes in the urdf:

0 deg

immagine

15 deg

immagine

cc @fiorisi @pattacini @xEnVrE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain-mechanics Related to Mechanics domain-software Related to Software report-bug Something isn't working team-fix Related to Team Fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants