Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify function makeIdsUnique() #49

Open
waruyama opened this issue May 22, 2021 · 0 comments
Open

Simplify function makeIdsUnique() #49

waruyama opened this issue May 22, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@waruyama
Copy link
Collaborator

Since we are not using the ònlyReferencedIds parameter anymore (or always set it to false), the function makeIdsUnique() can be simplified.

Also, the variable referencedIds is declared as an array in function makeIdsUnique().in line160.

var referencedIds = onlyReferenced ? [] : NULL;

This would not work anyways, because it is populated with the elements' id as the key:

referencedIds[id] = 1;

So let's remove the parameter and make the function makeIdsUnique() a litte bit smaller.

@waruyama waruyama added the enhancement New feature or request label May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant