Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential validation/testing leakage due to the absence of switching between train and eval modes #46

Open
jinhaoduan opened this issue Jul 6, 2024 · 0 comments

Comments

@jinhaoduan
Copy link

Thanks for releasing the code.

I noticed that there's no switching between model.train() mode and model.eval() mode when transitioning between the training and validation processes. Could this potentially lead to leakage of validation/test information (BN will track the statistics in the validation/testing set)?

Another minor issue is the incorrect parameter in

fake_sample1 = sample_from_model(pos_coeff, gen_diffusive_1, args.num_timesteps, x1_t, T, args)
The generator should be gen_diffusive_2 for T1 -> T2, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant