Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

TransactionalTaskDirectoryExecutor is increasing in complexity #97

Open
rjkip opened this issue Feb 17, 2017 · 1 comment
Open

TransactionalTaskDirectoryExecutor is increasing in complexity #97

rjkip opened this issue Feb 17, 2017 · 1 comment

Comments

@rjkip
Copy link
Contributor

rjkip commented Feb 17, 2017

TransactionalTaskDirectoryExecutor is currently tasked with:

  • Managing execution states: prerequisites checking, execution, cleaning up, and roll back.
  • Initiating rollback when a SIGINT is trapped during execution or cleaning up.
  • Rethrowing unhandled exceptions that occur during execution or cleaning up after rolling back changes.

A solution to this increasing complexity should be found before adding more. (Finite state machine perhaps?)

@rjkip rjkip modified the milestones: 2.1, 3.1.0 Feb 17, 2017
@rjkip
Copy link
Contributor Author

rjkip commented Feb 17, 2017

@DRvanR wrote:

👍 on the sentiment as a whole.

Not sure about the FSM, it seems sensible, but so would be a simple pipeline or for example middlewares when trying to split out responsibilities.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant