New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples/Combobox.html doesn't use layer #7

Open

wkeese opened this issue Nov 2, 2015 · 1 comment

Member

wkeese commented Nov 2, 2015

Running a build updates most of the samples files to wrap the original require in:

require(["deliteful-build/layer"], function(){
        require([...

However for some reason that doesn't happen for Combobox.html. (Unless it's something I messed up in my environment somehow.)

PS: Not sure if this should be filed here or against another project

Member

clmath commented Nov 17, 2015

It is working correctly for me. The wrapping is made using RegExp so it can be easily broken if the sample changes its structure.

The code doing this is here https://github.com/cjolif/sdk-utils/blob/master/build/tasks/updateSamples.js#L6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment