Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

illogical sourceName #33

Open
helmecke opened this issue Sep 23, 2020 · 3 comments
Open

illogical sourceName #33

helmecke opened this issue Sep 23, 2020 · 3 comments

Comments

@helmecke
Copy link

Describe the bug
sourceName shows partial filepath.

It is caused by the workaround in:
#30
iamcco/coc-diagnostic#49

Expected behavior
sourceName should contain the name of the linter not the filename.

Screenshots
image

Desktop (please complete the following information):

  • OS: Arch Linux (Linux 5.8.10-arch1-1)
@helmecke helmecke changed the title illogically sourceName illogical sourceName Sep 23, 2020
@iamcco
Copy link
Owner

iamcco commented Sep 23, 2020 •
edited
Loading

It's relative to:

cc @fsouza since #30, it can filter diagnostics for the current file by sourceNameFilter option. Is it still worth to show the file path?

@fsouza
Copy link
Contributor

fsouza commented Sep 23, 2020

Ohhh shoot, that was my bad. Yeah let's revert that change, I'll send another PR that sets the filename in the correct field.

@iamcco
Copy link
Owner

iamcco commented Sep 24, 2020

We don't need to revert the change, sourceName is now used by the sourceNameFilter options by pr #30 , we only need to do some change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fsouza @iamcco @helmecke