Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font map casing #7377

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Font map casing #7377

wants to merge 5 commits into from

Conversation

Alfonso-Martello
Copy link
Contributor

Fixes #7376

Copy link
Member

@pmconne pmconne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a known issue, see discussion in #6751. Please don't merge yet. JavaScript's case-insensitive comparison uses a different collation sequence than that used by iModels.

In what contexts is this causing a problem? Are people manually typing in font names?

@Alfonso-Martello
Copy link
Contributor Author

It is only causing problems in a niche situation for now. No one is manually typing font names. In drawing production, we are using TextStyleSettings stored in workspaces. TextStyleSettings reference their font by name.

Somehow we found two iModels that reference the same font but have different spellings (the first iModel has the font named “Arial” embedded while the second iModel has the font named “arial” embedded).

Our UI only shows text styles that have their font available in the iModel, so we were wondering why our “Arial” text style was not being listed for the iModel with “arial”.

We saw that line of code and thought it was a quick fix so opened this PR/issue. Happy to close as the issue is not pressing.

@pmconne
Copy link
Member

pmconne commented Nov 14, 2024

@khanaffan @ColinKerr what was the outcome of your iQacs collection re iTwin/imodel-native#722? Do we have any plans to change the collation sequence for newly-created iModels?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FontMap.getFont is case sensitive
3 participants