-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font map casing #7377
base: master
Are you sure you want to change the base?
Font map casing #7377
Conversation
common/changes/@itwin/core-backend/fontMapCase_2024-11-14-21-53.json
Outdated
Show resolved
Hide resolved
…3.json Co-authored-by: Arun George <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a known issue, see discussion in #6751. Please don't merge yet. JavaScript's case-insensitive comparison uses a different collation sequence than that used by iModels.
In what contexts is this causing a problem? Are people manually typing in font names?
It is only causing problems in a niche situation for now. No one is manually typing font names. In drawing production, we are using Somehow we found two iModels that reference the same font but have different spellings (the first iModel has the font named “Arial” embedded while the second iModel has the font named “arial” embedded). Our UI only shows text styles that have their font available in the iModel, so we were wondering why our “Arial” text style was not being listed for the iModel with “arial”. We saw that line of code and thought it was a quick fix so opened this PR/issue. Happy to close as the issue is not pressing. |
@khanaffan @ColinKerr what was the outcome of your iQacs collection re iTwin/imodel-native#722? Do we have any plans to change the collation sequence for newly-created iModels? |
Fixes #7376