Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add a separator line between itemlist #772

Open
arnoldas-v opened this issue Mar 18, 2024 · 1 comment
Open

Ability to add a separator line between itemlist #772

arnoldas-v opened this issue Mar 18, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@arnoldas-v
Copy link

Is your feature request related to a problem? Please describe.

It would be nice to have an ability to add a separator lines between items in GroupItemDef. It would allow to add a visual grouping between similar items without adding a submenu.

Something like that:
image

Describe the Solution you'd like

A convenient way to use this might look like this:

new GroupItemDef({
    items: [
      new ToolItemDef({ toolId: "0", label: "Tool1" }),
      new ToolItemDef({ toolId: "1", label: "Tool2" }),
      new ToolItemSeparator(),
      new ToolItemDef({ toolId: "2", label: "Tool3" }),
      new ToolItemDef({ toolId: "3", label: "Tool33" }),
      new ToolItemSeparator(),
      new ToolItemDef({ toolId: "4", label: "Tool4" }),
    ],
   itemsInColumn: 1,
  }),

Describe alternatives you've considered

No response

Additional context

No response

@GerardasB GerardasB added the enhancement New feature or request label Mar 18, 2024
@GerardasB GerardasB self-assigned this Mar 18, 2024
@GerardasB
Copy link
Collaborator

This is currently under UX consideration. I think we could introduce this behavior by simply re-using current toolbar item grouping mechanism https://www.itwinjs.org/reference/appui-react/toolbar/commontoolbaritem/grouppriority/
A good candidate for this change would be a new opt-in toolbar implementation: #602

@GerardasB GerardasB added the good first issue Good for newcomers label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants