Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In deployments use .env file consistent #113

Open
sverhoeven opened this issue Jun 3, 2024 · 2 comments
Open

In deployments use .env file consistent #113

sverhoeven opened this issue Jun 3, 2024 · 2 comments

Comments

@sverhoeven
Copy link
Member

In deploy/arq/ a .env file is used but not configured in compose file
In .devcontainer/ a .env file is used in webapp service, but you do own npm run dev so env is from that terminal.

Each compose file should in the webapp service have a section

    env_file:
      - path: .env
        required: false

And documentation should point the /.env.example as a starting point.

@sverhoeven
Copy link
Member Author

In

- HADDOCK3WEBAPP_REFRESH_RATE_MS
and var in .env file is passed through. If this line does not exist the var is also not set in the container.

Instead of repeating the var name, we should use the env_file section to pass through all vars set in the .env file.

@sverhoeven
Copy link
Member Author

Also would be nice to make sure that any env var used in the code is documented either in .env.example or the docs/ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant