Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tracing an optional feature #713

Open
seanmonstar opened this issue Sep 11, 2023 · 1 comment · May be fixed by #776
Open

Make tracing an optional feature #713

seanmonstar opened this issue Sep 11, 2023 · 1 comment · May be fixed by #776

Comments

@seanmonstar
Copy link
Member

Make tracing available as a Cargo feature, probably default off.

@tottoto tottoto linked a pull request May 8, 2024 that will close this issue
@glorv
Copy link

glorv commented Jun 20, 2024

While test integrating tonic into TiKV to replace grpc-rs, I found that tonic's performance is not as good as grpc-rs as it consumes more cpu. And from the profile, I saw that a lot of cpu time is cost by the tracing logic in h2. In some workloads, the qps with tonic can be 15% lower than grpc-rs. Here is a cpu profiling snapshot:

image

After patching tonic with a h2 package with all tracing code removed, tonic's performance is slightly better than gprc-rs in almost all workload without any further optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants