Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyperfiddle.electric-dom2/props reverses class order #73

Open
milelo opened this issue Aug 24, 2024 · 4 comments
Open

hyperfiddle.electric-dom2/props reverses class order #73

milelo opened this issue Aug 24, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@milelo
Copy link

milelo commented Aug 24, 2024

If I call:

(hyperfiddle.electric-dom2/props {:class "a b c"})

the dom shows: class="c b a".

@dustingetz
Copy link
Member

Is it damaging something?

@milelo
Copy link
Author

milelo commented Aug 25, 2024

Potentially. If two classes have a conflicting style property for example color, the latter one takes precedence.

@dustingetz
Copy link
Member

Thanks, we accept the bug. The root cause is that e/for mounts branches concurrently – they are racing. It is potentially straightforward to guarantee a mount ordering and we have been considering it.

@dustingetz dustingetz added the bug Something isn't working label Aug 26, 2024
@theronic
Copy link
Collaborator

theronic commented Dec 5, 2024

In Semantic UI, class names are order-dependent so e.g. (dom/props {:class "ui right aligned"}) renders to DOM as "aligned right ui", so I have to reverse the order to get text alignment working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants