Prevent users from iterating a request's body after having responded to that request

[Joannis]

Currently, we implement an HBRequest's Body with the NIOAsyncChannel's inbound. This is efficient, but might lead to users escaping the request.body for later consumption. This will lead to bugs.

[adam-fowler]

Are you talking about iterating the request body in an unstructured task?

[Joannis]

Exactly, but explicitly after the response was already returned

[adam-fowler]

You could set the request body to have been iterated as soon as the response body has finished writing. So any subsequent attempts to iterate via an unstructured task will fail and provide a better indication as to why it failed.

[JonPulfer]

I'm going to take a look at this for you. I'm at an intermediate stage with Swift, so will enjoy helping out while improving my skills 😃

[adam-fowler]

I'm going to take a look at this for you. I'm at an intermediate stage with Swift, so will enjoy helping out while improving my skills 😃

Hi Jon, what I mention above has been implemented but it doesn't really resolve the issue completely as the compiler stills allows you to iterate the request body in an unstructured Task. At this point in time there isn't really anything in Swift to resolve this issue but Swift 6 has a number of features that might help (~Escapable, better control of concurrency isolation) but they aren't available just now.

[JonPulfer]

Ah ok, thanks for letting me know :)

I’ll keep my eye open for something else I can take a look at.

[adam-fowler]

Ah ok, thanks for letting me know :)

I’ll keep my eye open for something else I can take a look at.

I can't think of anything obvious at the moment. But contributions are always welcome