Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Dark-theme Logo #1013

Open
jamesdeluk opened this issue Nov 7, 2024 · 2 comments
Open

Feature Request: Dark-theme Logo #1013

jamesdeluk opened this issue Nov 7, 2024 · 2 comments

Comments

@jamesdeluk
Copy link

jamesdeluk commented Nov 7, 2024

Describe the solution you'd like

Currently the logo on the home page is the same regardless of theme:

params:
  logo:
    main: logo.png

If the logo is dark, and the theme is switched to dark mode, the background behind the logo goes dark, which can obscure the logo.

As such, I propose an option to set a different logo for dark mode.

Describe alternatives you've considered

A CSS filter partially works, but is not ideal:

html[data-theme="dark"] .home img {
  -webkit-filter: invert(1);
  filter: invert(1);
  background-color: #xxxxxx; /* invert of dark mode colour */
}

Additional context

Slightly related to #902

@jamesdeluk jamesdeluk changed the title Feature Request Feature Request: Dark-theme Logo Nov 27, 2024
@BernatBC
Copy link
Contributor

Hi @jamesdeluk, which logo do you mean? The user avatar in the middle of the home screen, or the logo on the navbar?

@jamesdeluk
Copy link
Author

Hi @jamesdeluk, which logo do you mean? The user avatar in the middle of the home screen, or the logo on the navbar?

I guess both? But I was mainly thinking of the one in the middle of the home screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants