FIX: Avoid needless copy from modules_to_save #2220
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves huggingface#2206 NOT READY TO MERGE YET. Tentative solution to that issue. The problem is that we keep a "global" modules_to_save on the model which contains all possible modules_to_save for each adapter. When the first adapter targets layer "foo" with modules_to_save and the second adapter targets "bar", then "foo" will create a copy of the original module for the second adapter, even though it's not needed. This does not change the result but is unnecessary and takes up memory. Thus it should be avoided. TODO: Tests.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2206
NOT READY TO MERGE YET. Let's wait for the 0.14.0 release.
Tentative solution to that issue.
The problem is that we keep a "global"
modules_to_saveon themodelwhich contains all possiblemodules_to_savefor each adapter. When the first adapter targets layer "foo" withmodules_to_saveand the second adapter targets "bar", then "foo" will create a copy of the original module for the second adapter, even though it's not needed.This does not change the result but is unnecessary and takes up memory. Thus it should be avoided.