Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit Test] Add unit tests for DistributedTrainer #90

Open
xrsrke opened this issue Mar 2, 2024 · 5 comments
Open

[Unit Test] Add unit tests for DistributedTrainer #90

xrsrke opened this issue Mar 2, 2024 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed High Priority

Comments

@xrsrke
Copy link
Member

xrsrke commented Mar 2, 2024

No description provided.

@xrsrke xrsrke added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 2, 2024
@ashishpetwal
Copy link

I would like to contribute to this issue. Could you specify more about it?

@xrsrke
Copy link
Member Author

xrsrke commented Mar 2, 2024

@ashishpetwal like writing a unit test for

nanotron/run_train.py

Lines 136 to 140 in 9f117ee

trainer = DistributedTrainer(config_file)
dataloader = get_dataloader(trainer)
# Train
trainer.train(dataloader)

@xrsrke
Copy link
Member Author

xrsrke commented Mar 2, 2024

@ashishpetwal would you like to take it?

@ashishpetwal
Copy link

I haven't written tests in Python, but if it is beginner-friendly. I would love to take it. What do you think, is there a more learning curve?

@xrsrke
Copy link
Member Author

xrsrke commented Mar 2, 2024

we use pytest in nanotron https://github.com/pytest-dev/pytest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed High Priority
Projects
None yet
Development

No branches or pull requests

2 participants