Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable download stats for deepforest-tree and deepforest-bird #868

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

henrykironde
Copy link
Contributor

The models are produced using Deepforest, a python package.
https://github.com/weecology/DeepForest

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @henrykironde - left a suggestion that would be more future-proof as the library develops further and you release model checkpoints.

Note: After you've made changes, do make sure to add deepforest tag on the Hub model repos as well, you can add them similar to how I've added them here: https://huggingface.co/weecology/deepforest-tree/discussions/1

packages/tasks/src/model-libraries.ts Outdated Show resolved Hide resolved
packages/tasks/src/model-libraries.ts Show resolved Hide resolved
packages/tasks/src/model-libraries.ts Outdated Show resolved Hide resolved
henrykironde and others added 2 commits August 27, 2024 12:20
Co-authored-by: Lucain <[email protected]>
Co-authored-by: Vaibhav Srivastav <[email protected]>
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the changes :) I see that you've already added a model to https://huggingface.co/models?other=deepforest. Feel free to do the same with the rest of the models.

@Vaibhavs10 do you want to have a last look at it before merging?

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks a ton for iterating on this @henrykironde 🤗

also, thanks for bringing the tag to all the other repos: https://huggingface.co/models?other=deepforest

Will merge as soon as the CI is Green ✅

@Vaibhavs10 Vaibhavs10 merged commit caef921 into huggingface:main Aug 28, 2024
4 checks passed
@Wauplin
Copy link
Contributor

Wauplin commented Aug 28, 2024

@henrykironde I've checked the deepforest models and have two comments:

  • is it expected that cropmodel-deadtrees weights file is called cropmodel-deadtrees.pl (instead of a .pt extension)? If not, you can rename it with the "rename" button on this page.
  • it seems deepforest-livestock doesn't have a weights file yet so downloads are not counted (since nothing is been downloaded ^^)

@henrykironde henrykironde deleted the deepforest-tree branch August 28, 2024 14:28
@henrykironde
Copy link
Contributor Author

is it expected that [cropmodel-deadtrees](https://huggingface.co/weecology/cropmodel-deadtrees/tree/main) weights file is called cropmodel-deadtrees.pl

@Wauplin we do have both .pl and .pt, How can I update that ?

@Wauplin
Copy link
Contributor

Wauplin commented Aug 29, 2024

@henrykironde you can open a new PR to update the download count rule like this:

countDownloads: `path_extension:"pt" OR path_extension:"pl"`,

and it'll do the trick :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants