Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cp/ edge to supported libs. #864

Merged
merged 6 commits into from
Aug 28, 2024
Merged

add cp/ edge to supported libs. #864

merged 6 commits into from
Aug 28, 2024

Conversation

Vaibhavs10
Copy link
Member

No description provided.

packages/tasks/src/model-libraries.ts Outdated Show resolved Hide resolved
from transformers import AutoTokenizer

model = ReneLMHeadModel.from_pretrained("${model.id}").half().cuda()
tokenizer = AutoTokenizer.from_pretrained("allenai/OLMo-1B-hf")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest pushing the tokenizer to the new repo. Usually tokenizers also come in the model repo

packages/tasks/src/model-libraries-snippets.ts Outdated Show resolved Hide resolved
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with the comments discussed

repoUrl: "https://github.com/cartesia-ai/cartesia_pytorch",
snippets: snippets.cartesia_pytorch,
},
cartesia_mlx: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if this is the correct library_name - I will wait for confirmation before the merge.

packages/tasks/src/model-libraries-snippets.ts Outdated Show resolved Hide resolved
import cartesia_mlx as cmx

model = cmx.from_pretrained("${model.id}")
model.set_dtype(mx.float32)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary? (just curious)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to their official snippet, yes! but I haven't been able to test it till now.

@Vaibhavs10
Copy link
Member Author

Merging for now, will make follow-up updates as it comes!

@Vaibhavs10 Vaibhavs10 merged commit 9bed74e into main Aug 28, 2024
5 checks passed
@Vaibhavs10 Vaibhavs10 deleted the vb/add-cp-library branch August 28, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants