Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten signature #63

Open
mccalluc opened this issue Sep 22, 2022 · 0 comments
Open

Tighten signature #63

mccalluc opened this issue Sep 22, 2022 · 0 comments

Comments

@mccalluc
Copy link
Contributor

We had a bad kwarg:

... but didn't notice it because we were just wildcarding:

    @abstractmethod
    def get_conf_cells(self, **kwargs):
  • Make marker and explict kwarg everywhere.
  • If it's supplied to a constructor that doesn't want it, throw an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mccalluc