Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy between AS collisions in RUI and EUI #837

Open
danqaurooni opened this issue Nov 25, 2024 · 7 comments
Open

Discrepancy between AS collisions in RUI and EUI #837

danqaurooni opened this issue Nov 25, 2024 · 7 comments
Assignees
Labels
app: ccf-eui Exploration User Interface full application app: ccf-rui Registration User Interface bug 🐛 Something isn't working

Comments

@danqaurooni
Copy link

There is a discrepancy between the AS tags in the RUI and the EUI for the JSON below:

pryhuber.json

When I open it in the RUI, I get collision with the following ASes (note that the ASes were added manually):
Screenshot 2024-11-25 at 11 55 24 AM

But when I open it up in the EUI (https://hubmapconsortium.github.io/hra-registrations/hubmap-lung-pryhuber-2023/) and filter the results for that block, I don't get the same collisions:

Screenshot 2024-11-25 at 11 56 21 AM
@danqaurooni danqaurooni added the bug 🐛 Something isn't working label Nov 25, 2024
@bherr2
Copy link
Member

bherr2 commented Dec 2, 2024

Ok, I replaced the template with the latest EUI version, but still don't see it in the tree. I see all 4 annotations in the RUI location in the API response where it says what AS were collided with: https://apps.humanatlas.io/api/v1/ontology-term-occurences?token=57b0c5792985a62bd7c9d1562505effd. 3 of the 4 annotations aren't in https://apps.humanatlas.io/api/v1/ontology-tree-model, so it's probably something in how the tree is constructed (the ontologies aren't trees, so this is a possibility). It seems to be a bug in hra-api and might take a bit to resolve.

@bherr2
Copy link
Member

bherr2 commented Dec 4, 2024

Ok and looking at this further, its even worse. 3 of those annotations are no longer in the lung ASCT+B table. The tree is constructed from the tables, so that is why it doesn't show up in the list.

@bherr2
Copy link
Member

bherr2 commented Dec 4, 2024

@emquardokus these 3 structures are tagged in the 3d reference organ for lung, but do not occur in the v1.4 lung table:

@emquardokus
Copy link
Contributor

@emquardokus these 3 structures are tagged in the 3d reference organ for lung, but do not occur in the v1.4 lung table:

* http://purl.obolibrary.org/obo/UBERON_0002168 (left lung)

* http://purl.obolibrary.org/obo/UBERON_0008953 (lower lobe of left lung)

* http://purl.org/sig/ont/fma/fma7508 (Left posterior basal segmental bronchus)

@bherr2 v1.0 lung had left and right lung, but it was decided to make it a generic lung, so no lefts and rights of anything are in the ASCT+B table only in the 3D ref. models.
Same for all the L/R laterality organs like kidney, ureter, mammary gland, ovary, fallopian tube etc---only in 3D ref models, not in ASCT+B tables.

@bherr2
Copy link
Member

bherr2 commented Dec 4, 2024

Yeah, so I'm wondering how we get those anatomical structure tags from the 3D reference organs when they use the RUI to show up in the EUI's AS partonomy on the left. The AS partonomy is built from the ASCT+B tables, so terms that don't show up there don't get highlighted even though there are RUI locations that have those terms.

@emquardokus
Copy link
Contributor

emquardokus commented Dec 4, 2024

hmmm, good point. I don't think there is any intention on going back to laterality in ASCT+B tables due to high redundancy, which was why it was simplified.
Is there a different method by which we could incorporate the laterality into the EUI listing?
Part of the issue too is that the actual datasets are still only mapped at the organ level on IEC and other databases.

@bherr2
Copy link
Member

bherr2 commented Dec 4, 2024

Ok, yeah, we'll have to think about how to handle this

@LibbyUX LibbyUX added app: ccf-eui Exploration User Interface full application app: ccf-rui Registration User Interface labels Dec 12, 2024
@LibbyUX LibbyUX added this to the Ideation: DS Expansion milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: ccf-eui Exploration User Interface full application app: ccf-rui Registration User Interface bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants