-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discrepancy between AS collisions in RUI and EUI #837
Comments
Ok, I replaced the template with the latest EUI version, but still don't see it in the tree. I see all 4 annotations in the RUI location in the API response where it says what AS were collided with: https://apps.humanatlas.io/api/v1/ontology-term-occurences?token=57b0c5792985a62bd7c9d1562505effd. 3 of the 4 annotations aren't in https://apps.humanatlas.io/api/v1/ontology-tree-model, so it's probably something in how the tree is constructed (the ontologies aren't trees, so this is a possibility). It seems to be a bug in hra-api and might take a bit to resolve. |
Ok and looking at this further, its even worse. 3 of those annotations are no longer in the lung ASCT+B table. The tree is constructed from the tables, so that is why it doesn't show up in the list. |
@emquardokus these 3 structures are tagged in the 3d reference organ for lung, but do not occur in the v1.4 lung table:
|
@bherr2 v1.0 lung had left and right lung, but it was decided to make it a generic lung, so no lefts and rights of anything are in the ASCT+B table only in the 3D ref. models. |
Yeah, so I'm wondering how we get those anatomical structure tags from the 3D reference organs when they use the RUI to show up in the EUI's AS partonomy on the left. The AS partonomy is built from the ASCT+B tables, so terms that don't show up there don't get highlighted even though there are RUI locations that have those terms. |
hmmm, good point. I don't think there is any intention on going back to laterality in ASCT+B tables due to high redundancy, which was why it was simplified. |
Ok, yeah, we'll have to think about how to handle this |
There is a discrepancy between the AS tags in the RUI and the EUI for the JSON below:
pryhuber.json
When I open it in the RUI, I get collision with the following ASes (note that the ASes were added manually):
But when I open it up in the EUI (https://hubmapconsortium.github.io/hra-registrations/hubmap-lung-pryhuber-2023/) and filter the results for that block, I don't get the same collisions:
The text was updated successfully, but these errors were encountered: